[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 23 17:58:52 PDT 2021


JDevlieghere added inline comments.


================
Comment at: lldb/source/API/SBThread.cpp:853
+    if (!location_spec) {
+      sb_error.SetErrorString(
+          llvm::toString(location_spec.takeError()).c_str());
----------------
Why not `sb_error = location_spec.takeError()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100965/new/

https://reviews.llvm.org/D100965



More information about the lldb-commits mailing list