[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 23 15:19:22 PDT 2021


mgorny updated this revision to Diff 340177.
mgorny added a comment.

Added `Extension` bit for `multiprocess`. Made `fork-events` and `vfork-events` both depend on it — i.e. be implicitly disabled if `multiprocess` wasn't reported as supported.

Simplify `GDBRemoteCommunicationServerLLGS::SetEnabledExtensions()` — we can just take the value instead of copying it bit-by-bit ;-).

Move `add_qSupported_packets()` change from later patch. Add tests for `qSupported` responses (particularly, rejecting `[v]fork-events` if `multiprocess` is not present). The new tests are in `fork` category that's skipped on all platforms where fork/vfork isn't enabled yet (i.e. everywhere in this patch).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100153/new/

https://reviews.llvm.org/D100153

Files:
  lldb/include/lldb/Host/common/NativeProcessProtocol.h
  lldb/packages/Python/lldbsuite/test/dotest.py
  lldb/packages/Python/lldbsuite/test/test_categories.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100153.340177.patch
Type: text/x-patch
Size: 12096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210423/b76ff7c5/attachment-0001.bin>


More information about the lldb-commits mailing list