[Lldb-commits] [PATCH] D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 23 14:07:58 PDT 2021


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:946-948
+    response.Printf("%s:p%" PRIx64 ".%" PRIx64 ";", reason_str,
+                    tid_stop_info.details.fork.child_pid,
+                    tid_stop_info.details.fork.child_tid);
----------------
labath wrote:
> I just realized this is implicitly assuming the multiprocess extension is enabled/supported. That makes sense since forking always involves multiple processes, though maybe the server should check that the client actually reports it as supported.
Makes sense. I'll add it to the extension patch since that's where we determine if fork/vfork is supported.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100196/new/

https://reviews.llvm.org/D100196



More information about the lldb-commits mailing list