[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 23 13:20:58 PDT 2021


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:402-403
+      is_vfork ? StopReason::eStopReasonVFork : StopReason::eStopReasonFork;
+  m_stop_info.details.fork.child_pid = child_pid;
+  m_stop_info.details.fork.child_tid = child_pid;
+}
----------------
labath wrote:
> Still duplicated. :)
I'm confused. Maybe you're not noticing the tiny one-letter difference, i.e. `pid` vs `tid`? ;-) Linux is the only target where both are equal and the stop info needs to be generic, so that other platforms can assign distinct `pid` and `tid`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100208/new/

https://reviews.llvm.org/D100208



More information about the lldb-commits mailing list