[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/API/SBThread.cpp:852
+    auto location_spec = SourceLocationSpec::Create(
+        step_file_spec, line, column, check_inlines, exact);
+    lldbassert(location_spec && "Invalid SourceLocationSpec.");
----------------
```
step_file_spec, line, /*column*/llvm::None, check_inlines, exact);
```


================
Comment at: lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp:114
+    auto location_spec = SourceLocationSpec::Create(
+        cu_file_spec, line_matches[i], column, search_inlines, m_exact_match);
+    lldbassert(location_spec && "Invalid SourceLocationSpec.");
----------------
```
cu_file_spec, line_matches[i], /*column*/llvm::None, search_inlines, m_exact_match);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100965/new/

https://reviews.llvm.org/D100965