[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

Thank you, this is awesome.



================
Comment at: lldb/docs/resources/test.rst:206
+
+**Don't unnecessarily launch the test executable.**
+    Launching a process and running to a breakpoint can often be the most
----------------
While I agree with this, it also feels unhelpful because it does not give any examples nor explain the alternatives.

I can see the problem with pointing at specific tests which may disappear or change. I can also see the problem with attempting to enumerate all the possibilities below this as well.

Maybe we need a set of example tests as well?

Most of the rest of advice stands alone pretty well though. 


================
Comment at: lldb/docs/resources/test.rst:264
+::
+    self.expect("expr 1 - 1", substrs=["0"])
+
----------------
Maybe some more examples with alternatives would be helpful here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101153/new/

https://reviews.llvm.org/D101153