[Lldb-commits] [PATCH] D100898: [CMake][lldb] add_lldb_library's functions require default visibility

[Jim Radford via lldb-commits]

Yes, this IMO should eventually be addressed by explicitly exporting each meant-to-be-exported function with LLDB_ABI and then changing the line this patch adds to use `hidden` instead of `default`.

This patch is meant to be a band-aid until that can be done.

> On Apr 20, 2021, at 11:58 PM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added a comment.
> 
> Is there a way to address this through the preprocessor? We already have the `LLDB_API` macro, which expands to `__declspec(dllexport/import)` on windows. Would expanding it do `__attribute__((visibility("default")))` (or something) on other platforms help with anything?
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D100898/new/
> 
> https://reviews.llvm.org/D100898
>