[Lldb-commits] [lldb] 034c73d - [lldb][NFC] Fix unsigned/signed cmp warning in MainLoopTest

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 22 03:20:50 PDT 2021


Author: Raphael Isemann
Date: 2021-04-22T12:20:32+02:00
New Revision: 034c73d42e4655ae247fc1f72dc3d2d6c621ab23

URL: https://github.com/llvm/llvm-project/commit/034c73d42e4655ae247fc1f72dc3d2d6c621ab23
DIFF: https://github.com/llvm/llvm-project/commit/034c73d42e4655ae247fc1f72dc3d2d6c621ab23.diff

LOG: [lldb][NFC] Fix unsigned/signed cmp warning in MainLoopTest

The gtest checks compare all against unsigned int constants so this also needs
to be unsigned.

Added: 
    

Modified: 
    lldb/unittests/Host/MainLoopTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Host/MainLoopTest.cpp b/lldb/unittests/Host/MainLoopTest.cpp
index 50a49b92d48b..890f6eb66197 100644
--- a/lldb/unittests/Host/MainLoopTest.cpp
+++ b/lldb/unittests/Host/MainLoopTest.cpp
@@ -158,8 +158,8 @@ TEST_F(MainLoopTest, UnmonitoredSignal) {
 TEST_F(MainLoopTest, TwoSignalCallbacks) {
   MainLoop loop;
   Status error;
-  int callback2_count = 0;
-  int callback3_count = 0;
+  unsigned callback2_count = 0;
+  unsigned callback3_count = 0;
 
   auto handle = loop.RegisterSignal(SIGUSR1, make_callback(), error);
   ASSERT_TRUE(error.Success());


        


More information about the lldb-commits mailing list