[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 21 10:58:18 PDT 2021


clayborg added a comment.

Much of this patch requires all places that took a DWARFDie object now also must take an extra parameter. Is there really no way to have DWARFDie be able to discover the main unit via its contained DWARFUnit?  DWARFDie objects are transient, so they can contain more information that just what they currently contain:

  class DWARFDie {
    DWARFUnit *U = nullptr;
    const DWARFDebugInfoEntry *Die = nullptr;
  };

Can we add a new "DWARFUnit *MU;" to the DWARFDie class? Is there really not way to ask the contained "U" DWARFUnit member for the main unit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96236/new/

https://reviews.llvm.org/D96236



More information about the lldb-commits mailing list