[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 21 10:18:57 PDT 2021


jingham added a comment.

It seems like most of the places where you use the SourceLocationSpec, you also pass "check_inlines" and "exact".  Those seem to me natural parts of a source location search specification class, and including them in the Spec would clean up the API's even further.  Not necessary if it gets ugly for some reason, but it would look nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100965/new/

https://reviews.llvm.org/D100965



More information about the lldb-commits mailing list