[Lldb-commits] [PATCH] D100891: CMake fixes to enable LLVM as a sub-project

[Jim Radford via Phabricator via lldb-commits]

radford created this revision.
Herald added a subscriber: mgorny.
radford requested review of this revision.
Herald added projects: clang, LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits.

[CMake][llvm] Using -D in COMPILE_DEFINITIONS can create a lone -D w/generator-expressions

[CMake][llvm] LLVM_DEFINITIONS are a list, not space separated

[CMake][clang] add_clang_library's functions require default visibility

[CMake][lldb] add_lldb_library's functions require default visibility

[CMake][llvm] add_llvm_library's functions require default visibility

[CMake][llvm] avoid changing global flags (may be used outside of llvm)

Changing global flags can break builds of projects that include/build
llvm as a sub-project, as the effect is global.  Ideally we would
disable this warning at the directory level instead, but the obvious
way (disabling warning D9025 <https://reviews.llvm.org/D9025>) isn't supported.  At least we can limit
the effect to only MSVC.

[CMake][llvm] The first argument to check_linker_flag is the language

[CMake][llvm] avoid includes with generator-expressions in add_custom_command


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100891

Files:
  clang/cmake/modules/AddClang.cmake
  lldb/cmake/modules/AddLLDB.cmake
  llvm/cmake/modules/AddLLVM.cmake
  llvm/cmake/modules/AddLLVMDefinitions.cmake
  llvm/cmake/modules/HandleLLVMOptions.cmake
  llvm/cmake/modules/TableGen.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100891.339001.patch
Type: text/x-patch
Size: 5108 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210420/0444ac43/attachment-0001.bin>