[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data
David Zarzycki via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 15 07:28:18 PDT 2021
davezarzycki added a comment.
In D98179#2689079 <https://reviews.llvm.org/D98179#2689079>, @lebedev.ri wrote:
> In D98179#2689075 <https://reviews.llvm.org/D98179#2689075>, @mstorsjo wrote:
>> Something related to the time recording seems to fail intermittently on buildbots: https://lab.llvm.org/buildbot#builders/93/builds/2697
> I'll cut to the fix here: @davezarzycki is there any reason why the timing data is stored in a CSV format, and not JSON?
> The fix is to switch to latter.
What? Weird. The file isn't CSV. It's just a number followed by a space and then everything until the newline is the file name. Nothing fancy. Switching to JSON probably just means papering over the real problem which seems to be either that sometimes a test has an empty string for a name or that there is an edge case in python's number printing that can result in pure whitespace. We'd need to look at the timing data file to see why it's bogus (or corrupt).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits