[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

Fri Apr 16 15:03:51 PDT 2021

jasonmolenda added a comment.

In D100515#2695559 <https://reviews.llvm.org/D100515#2695559>, @JDevlieghere wrote:

> In D100515#2695395 <https://reviews.llvm.org/D100515#2695395>, @justincohen wrote:
>
>> Out of curiosity: Typically should one be able to set target.process.virtual-addressable-bits after the target has been created?  Or is it expected that users will need to run in the following order only:
>>
>>   settings set target.process.virtual-addressable-bits ...
>>   target create -c ....
>>
>> Setting virtual-addressable-bits won't do anythin after the target has been created (and perhaps that is working as intended?)
>
> Yep, that was exactly why I'm always reading the setting if the mask isn't set yet (as opposed to setting it once in the constructor).

And it's an open question of what's the correct behavior if there's a dynamically-set value AND a user specified setting.  The patch currently prefers the dynamically-set value and I think that's the right choice, but it'll be interesting to see if there's a platform/system where that doesn't work for some users.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100515/new/

https://reviews.llvm.org/D100515