[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

[Justin Cohen via Phabricator via lldb-commits]

justincohen accepted this revision.
justincohen added a comment.
This revision is now accepted and ready to land.

> On Darwin, we use the same number of bits for both code and data, but given the way ptrace() behaves on Linux, I'm guessing this may not be the case everywhere.  Should we store both masks, and add FixCodeAddress + FixDataAddress methods in the ABI's, Justin?  What do you think?

This all LGTM!  I don't have a strong opinion on naming.  My understanding is both code and data will be necessary in case TBID0 is set on Linux.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100515/new/

https://reviews.llvm.org/D100515