[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 15 01:39:42 PDT 2021


DavidSpickett added a comment.

> I don't feel strongly about the method name. Justin used Process::GetPointerAuthenticationAddressMask which makes it sound specific to ARM v8.3 ptrauth. The ARM v8.5 MTE tagging might be another use case (or TBI as Omair has noted).

I'd go with the generic code/address name for the full masks (which would remove MTE/PAC/TBI all at once) and if we find situations where you only need one, add those as separate methods.
(maybe we already have a few of those situations, just my guess that most callers want to remove all the non address bits)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100515/new/

https://reviews.llvm.org/D100515



More information about the lldb-commits mailing list