[Lldb-commits] [lldb] ebee457 - [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash reports
Shafik Yaghmour via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 14 16:28:45 PDT 2021
Author: Shafik Yaghmour
Date: 2021-04-14T16:28:38-07:00
New Revision: ebee45713190d9844ef860bf491035e3dcf3a538
URL: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538
DIFF: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538.diff
LOG: [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash reports
We have seen several crashes in LibCppStdFunctionCallableInfo(...) but we don't have a
reproducer. The last crash pointed to last call to line_entry_helper(...) and symbol
was a nullptr. So adding a check for this case.
Added:
Modified:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
Removed:
################################################################################
diff --git a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
index 02d9bff9eee3..ff2c064ee388 100644
--- a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
@@ -322,6 +322,9 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
}
}
+ if (symbol == nullptr)
+ return optional_info;
+
// Case 1 or 3
if (scl.GetSize() >= 1) {
optional_info = line_entry_helper(target, scl[0], symbol,
More information about the lldb-commits
mailing list