[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 added a comment.
Herald added a subscriber: JDevlieghere.

This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps `PacketDelayMultiplier` nanoseconds per byte read or written in `GDBRemoteCommunication`.

I'm not 100% sure on some choices I made, which I'd like to ask you all:

- In order to pass the delay seeting from `ProcessGDBRemote` to `GDBRemoteCommunication`, I've added a ivar to the latter, and am passing it through its constructor. This isn't ideal since once the object is build, updating the setting won't affect LLDB, but `GDBRemoteCommunication` currently has no knowledge of `ProcessGDBRemote` and the settings class (`PluginProperties`) is declared inside `ProcessGDBRemote.cpp`. Can I move the declaration of `PluginProperties` to  `ProcessGDBRemote.h` and import that in `GDBRemoteCommunication.cpp`?
- I've made `Read` and `Write` virtual in `Communication.h`. It seems that this was the initial intention (at least for `Write`), as its documentation states that "Subclasses must override this function". Is this all right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100500/new/

https://reviews.llvm.org/D100500