[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 14 12:02:36 PDT 2021
labath added a comment.
We should also start thinking about tests. I suppose the smallest piece of functionality that could be usefully tested (with a lldb-server test) is debugging a process that forks, stopping after the fork, and detaching from the child. Shall we try making that work first?
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3249
+ if (!detached)
+ return SendErrorResponse(Status("PID %" PRIu64 " not traced", pid));
> labath wrote:
> > Open question: Should we return an error for a plain `D` packet, if we don't have _any_ processes around?
> Practically, it probably doesn't matter. However, if client sends `D` without actually having process attached, then something has probably gone wrong, so might make sense to return some error.
True. I suppose we could just go with whatever falls out naturally from the code, and not add any special code on account of that.
CHANGES SINCE LAST ACTION
More information about the lldb-commits