[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 14 08:55:31 PDT 2021


JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.h:129-134
+  Broadcaster m_async_broadcaster; ///< The broadcaster emitting process/thread
+                                   /// state change events.
+  lldb::ListenerSP m_async_listener_sp; ///< The listener waiting for
+                                        /// process/thread state change events.
+  HostThread m_async_thread; ///< The separate lldb thread that monitors events.
+  std::recursive_mutex m_async_thread_state_mutex;
----------------
The trailing comments are a real pain with the 80 col limit and we're actively moving away from them. Please use `///` above the line instead or consider documenting the whole thing with a comment group. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100384/new/

https://reviews.llvm.org/D100384



More information about the lldb-commits mailing list