[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Sorry for the delay!

>From my playing around it look like if you do all the same steps as you show in your example, except that you leave out the call to "Persist" and instead directly use the SBValue from the expression directly, then everything works correctly.

If that's true then the original persistent variable we made for the expression result was working correctly, and something about Persist messed it up.  That's not 100% surprising, since we're "re-persisting" an already persistent variable...

If persisting already persistent variables is indeed the only failure case, then I wonder if it wouldn't be more straightforward to just see if the ValueObject is already a persistent variable and have Persist just return the incoming variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98370/new/

https://reviews.llvm.org/D98370