[Lldb-commits] [PATCH] D100256: [gdb-remote server] Abstract away getting current process

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 13 08:15:41 PDT 2021


mgorny updated this revision to Diff 337154.
mgorny retitled this revision from "[lldb] [gdb-remote server] Abstract away getting current process" to "[gdb-remote server] Abstract away getting current process".
mgorny edited the summary of this revision.
mgorny added a comment.

Switched to using two pointers instead of a function. Made `ReadTid()` accept a default PID instead of playing with bools. Corrected `Hc` PID to apply only to c/C/s/vCont packets, similarly to how GDB does it.

@labath, I've left the `GetID()` asserts in place because I've just did a big search/replace, and replacing them would be non-trivial and I can't really spend much more time on this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100256/new/

https://reviews.llvm.org/D100256

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100256.337154.patch
Type: text/x-patch
Size: 43680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210413/6442ec21/attachment-0001.bin>


More information about the lldb-commits mailing list