[Lldb-commits] [lldb] 29a4d78 - [lldb][AArch64] Only run MTE memory region test if we have MTE

[David Spickett via lldb-commits]

Author: David Spickett
Date: 2021-04-13T15:40:38+01:00
New Revision: 29a4d7813c75c1fbbd7afef33d32dde92598d1ad

URL: https://github.com/llvm/llvm-project/commit/29a4d7813c75c1fbbd7afef33d32dde92598d1ad
DIFF: https://github.com/llvm/llvm-project/commit/29a4d7813c75c1fbbd7afef33d32dde92598d1ad.diff

LOG: [lldb][AArch64] Only run MTE memory region test if we have MTE

This test is flakey because it tries to read the proc/smaps
file of the first lldb-server process it finds. This process
can finish before we finish doing that.

http://lab.llvm.org:8011/#/builders/96/builds/6634/steps/6/logs/stdio

For now limit this to MTE targets which basically means
QEMU via lldb-dotest, which doesn't have this issue.

I'll fix the race condition shortly.

Added: 
    

Modified: 
    lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py b/lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py
index ff8e01cb28c8c..3855a5aa5d73a 100644
--- a/lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py
+++ b/lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py
@@ -20,6 +20,8 @@ class AArch64LinuxMTEMemoryRegionTestCase(TestBase):
     @skipIf(archs=no_match(["aarch64"]))
     @skipUnlessPlatform(["linux"])
     def test_mte_regions(self):
+        if not self.isAArch64MTE():
+            self.skipTest('Target must support MTE.')
         if not self.hasLinuxVmFlags():
             self.skipTest('/proc/{pid}/smaps VmFlags must be present')