[Lldb-commits] [PATCH] D100256: [lldb] [gdb-remote server] Abstract away getting current process

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 13 07:41:14 PDT 2021

labath added a comment.

In D100256#2685807 <https://reviews.llvm.org/D100256#2685807>, @mgorny wrote:

> In D100256#2685632 <https://reviews.llvm.org/D100256#2685632>, @labath wrote:
>> Does this actually need to be a function? It seems like this could just be a pointer variable (or two), pointing into our pool of processes. I'd consider making a small struct to group the current process and the current thread within that process.
> I suppose a pointer might work for the proposed design. However, I'm wondering why we have the `GetID()` check here — can we have an invalid value of `m_debugged_process_up` then?

I think someone was just being overly cautious. I'm pretty sure the check is redundant...



More information about the lldb-commits mailing list