[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

Tue Apr 13 06:59:28 PDT 2021

labath added a comment.

One more thing I forgot to mention: In the all-paths-are-relative scenario, lldb will need some help with finding the source files. I believe that currently these will still be resolved relative to CWD, and that's something you may not want (?) Unlike dwos, this can be worked around currently by manually setting the target.source-map setting. It's not for this patch, but I think this is something you may want  to happen automatically as well (?)

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/dwo-relative-path.s:11
+
+# RUN: %lldb %T/dwo-relative-path -o "br set -n main" -o run -o step -o "frame var x" -b 2>&1 | FileCheck %s
+# CHECK: stop reason = breakpoint
----------------
Could you make the test case not involve running (so that it can work on non-linux systems too)? You should be able to simply observe the value of a global variable (target variable x) or something like that. Also, that means the executable does not need to contain the main function (and everything that goes with it), which would significantly reduce the size of the test input.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97786/new/

https://reviews.llvm.org/D97786