[Lldb-commits] [lldb] f152472 - [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests
David Spickett via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 13 05:51:54 PDT 2021
Author: David Spickett
Date: 2021-04-13T12:51:48Z
New Revision: f152472af576e77f9b8736dafaffd31fce7b13b0
URL: https://github.com/llvm/llvm-project/commit/f152472af576e77f9b8736dafaffd31fce7b13b0
DIFF: https://github.com/llvm/llvm-project/commit/f152472af576e77f9b8736dafaffd31fce7b13b0.diff
LOG: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests
These tests fail if you build without the x86 llvm backend.
Either because they use an x86 triple or try to backtrace which
requires some x86 knowledge to see all frames.
Reviewed By: labath
Differential Revision: https://reviews.llvm.org/D100194
Added:
Modified:
lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test
lldb/test/Shell/Minidump/disassemble-no-module.yaml
lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test
lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp
lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp
lldb/test/Shell/SymbolFile/symbol-binding.test
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
index 76fd8746aa2a1..39e96a65f7389 100644
--- a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
+++ b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
@@ -124,6 +124,7 @@ def test_thread_info_in_minidump(self):
stop_description = thread.GetStopDescription(256)
self.assertIn("SIGSEGV", stop_description)
+ @skipIfLLVMTargetMissing("X86")
def test_stack_info_in_minidump(self):
"""Test that we can see a trivial stack in a breakpad-generated Minidump."""
# target create linux-x86_64 -c linux-x86_64.dmp
@@ -362,6 +363,7 @@ def do_change_pid_in_minidump(self, core, newcore, offset, oldpid, newpid):
newpid += "\n"
f.write(newpid.encode('utf-8'))
+ @skipIfLLVMTargetMissing("X86")
def test_deeper_stack_in_minidump_with_same_pid_running(self):
"""Test that we read the information from the core correctly even if we
have a running process with the same PID"""
@@ -373,6 +375,7 @@ def test_deeper_stack_in_minidump_with_same_pid_running(self):
str(os.getpid()))
self.do_test_deeper_stack("linux-x86_64_not_crashed", new_core, os.getpid())
+ @skipIfLLVMTargetMissing("X86")
def test_two_cores_same_pid(self):
"""Test that we handle the situation if we have two core files with the same PID """
new_core = self.getBuildArtifact("linux-x86_64_not_crashed-pid.dmp")
@@ -385,6 +388,7 @@ def test_two_cores_same_pid(self):
new_core, self._linux_x86_64_pid)
self.test_stack_info_in_minidump()
+ @skipIfLLVMTargetMissing("X86")
def test_local_variables_in_minidump(self):
"""Test that we can examine local variables in a Minidump."""
# Launch with the Minidump, and inspect a local variable.
diff --git a/lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test b/lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test
index dfa98c5665611..e3f1e33e0ff0f 100644
--- a/lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test
+++ b/lldb/test/Shell/Minidump/Windows/Sigsegv/sigsegv.test
@@ -1,3 +1,5 @@
+// REQUIRES: x86
+
// RUN: cd %p/Inputs
// RUN: env LLDB_USE_NATIVE_PDB_READER=1 \
// RUN: %lldb -c sigsegv.dmp -s sigsegv.lldbinit | FileCheck %s
diff --git a/lldb/test/Shell/Minidump/disassemble-no-module.yaml b/lldb/test/Shell/Minidump/disassemble-no-module.yaml
index 64cd1145f317c..00c12c8b9ab93 100644
--- a/lldb/test/Shell/Minidump/disassemble-no-module.yaml
+++ b/lldb/test/Shell/Minidump/disassemble-no-module.yaml
@@ -1,3 +1,5 @@
+# REQUIRES: x86
+
# RUN: yaml2obj %s -o %t
# RUN: %lldb -c %t -o bt -o disassemble 2>&1 | FileCheck %s
diff --git a/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test b/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test
index 1c1dabec59447..0bcebaa00540d 100644
--- a/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test
+++ b/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-raSearch.test
@@ -1,3 +1,5 @@
+# REQUIRES: x86
+
# RUN: yaml2obj %S/Inputs/unwind-via-stack-win.yaml -o %t
# RUN: %lldb -c %t \
# RUN: -o "target symbols add %S/Inputs/unwind-via-raSearch.syms" \
diff --git a/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml b/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
index 8309c9e105e00..6075c33bb88ab 100644
--- a/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
+++ b/lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml
@@ -1,3 +1,5 @@
+# REQUIRES: x86
+
# RUN: yaml2obj --docnum=1 %s -o %t.dmp
# RUN: yaml2obj --docnum=2 %s -o %T/unwind-via-stack-win-no-memory-info.exe
# RUN: %lldb -c %t.dmp %T/unwind-via-stack-win-no-memory-info.exe \
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp b/lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
index d5365f1832fbe..7d0c0b8e684ba 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
@@ -1,5 +1,5 @@
// clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
// Test that we can show disassembly and source.
// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp b/lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp
index 312fd1e64bb5b..42fd21637ea8a 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp
@@ -1,5 +1,5 @@
// clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
// RUN: %clang_cl --target=i386-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s
// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp b/lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp
index 7603a4daba406..ac3ecbbbf09df 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/s_constant.cpp
@@ -1,5 +1,5 @@
// clang-format off
-// REQUIRES: lld
+// REQUIRES: lld, x86
// Test that we can display S_CONSTANT records.
diff --git a/lldb/test/Shell/SymbolFile/symbol-binding.test b/lldb/test/Shell/SymbolFile/symbol-binding.test
index 35faf844e9cc6..c6b141cfc35c7 100644
--- a/lldb/test/Shell/SymbolFile/symbol-binding.test
+++ b/lldb/test/Shell/SymbolFile/symbol-binding.test
@@ -1,3 +1,5 @@
+# REQUIRES: x86
+
# Some targets do not have the .size directive.
# RUN: %clang -target x86_64-unknown-unknown-elf %S/Inputs/symbol-binding.s -c -o %t.o
# RUN: %lldb %t.o -s %s -o quit | FileCheck %s
More information about the lldb-commits
mailing list