[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

Tue Apr 13 04:51:01 PDT 2021

labath added inline comments.

================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1036
+    std::unique_ptr<NativeProcessProtocol> &child_process) {
+  // Apparently the process has been dealt with by another delegate.
+  if (!child_process)
----------------
mgorny wrote:
> labath wrote:
> > You no longer have to worry about that...
> Don't I? The process plugin puts the new instance in an `std::unique_ptr`, and passes that to all delegates. Only one delegate can take the pointer over. While I don't think we really have a case for multiple delegates doing `NewSubprocess()`, I suppose we should check rather than crash. Or maybe just put an `assert` for it.
I deleted the multi-delegate thingy in c9cf394f796e1 ;)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100191/new/

https://reviews.llvm.org/D100191