[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 13 03:01:15 PDT 2021


labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1310-1311
+      "QStartNoAckMode+",
+      "QThreadSuffixSupported+",
+      "QListThreadsInStopReply+",
+      "qEcho+",
----------------
mgorny wrote:
> labath wrote:
> > I think that these two should also be llgs-specific.
> I actually left them here because the respective `Handle_QThreadSuffixSupported` and `Handle_QListThreadsInStopReply` methods are also in common.
Fair enough. I'll see what I can do about that once this patch lands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100140/new/

https://reviews.llvm.org/D100140



More information about the lldb-commits mailing list