[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

In D100146#2684942 <https://reviews.llvm.org/D100146#2684942>, @labath wrote:

> looks great, just fix the build errors :)

Yeah, I'm trying to see if I can reproduce them when building with Clang.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:375
+
+    for (auto x : server_features) {
+      if (x == "qXfer:auxv:read+")
----------------
labath wrote:
> not a big deal, but this probably shouldn't be auto.
Could you explain a bit? I thought `auto` is convenient here since the actual type is visible three lines higher.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100146/new/

https://reviews.llvm.org/D100146