[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added subscribers: jingham, clayborg.
jasonmolenda added a comment.

Trying to reword my thinking a little more clearly.

Process::ReadMemory - only works when you have a Process.  Always reads directly from memory.

Target::ReadMemory - can be used with or without a Process.

1. If force_live_memory == true, will read from memory if there is a Process.  Else will read from file, if a Section covers this address.

2. If the address is in a Section that is read-only, read from the file.

3. If the address is in a section that is read-write, read from memory if there is a Process.  Else read from the file, if a Section covers this address.

And I would make Target::ReadMemory's force_live_memory argument have a default value of false, because few people intend for this.

I'm open to hearing different opinions on this rethink!  eg  @clayborg @jingham


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100338/new/

https://reviews.llvm.org/D100338