[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Target/Target.cpp:1760
+      auto permissions = section_sp->GetPermissions();
+      prefer_file_cache |= (permissions & ePermissionsWritable) == 0 &&
+                          (permissions & ePermissionsReadable) == 1;
----------------
With https://lldb.llvm.org/cpp_reference/classlldb__private_1_1Flags.html
you can write this as `Flags(permissions).Test(ePermissionsWritable)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100338/new/

https://reviews.llvm.org/D100338