[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

Thu Apr 8 15:33:05 PDT 2021

mgorny added a comment.

In D98822#2677961 <https://reviews.llvm.org/D98822#2677961>, @JDevlieghere wrote:

> `test/Shell/Subprocess/vfork-follow-parent-wp.test` is failing on GreenDragon:
>
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31016/testReport/junit/lldb-shell/Subprocess/vfork_follow_parent_wp_test/
>
> I'm going to temporarily disable the test on Darwin. Happy to provide help to investigate :-)

I guess that `vfork()`-ed process doesn't start with cleared dbregs on Darwin. I suppose you don't handle forks at all, so I suppose skipping/xfailing the test is the thing to do — knowing that there's a potential issue but extremely unlikely in real life.

Forks are handled explicitly on FreeBSD, Linux and NetBSD right now but I've left these tests open to all platforms since they merely verify that LLDB doesn't explode when the debugged program forks, and that it (probably) doesn't try to debug the child accidentally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98822/new/

https://reviews.llvm.org/D98822