[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 8 15:23:53 PDT 2021


mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski.
mgorny requested review of this revision.

Refactor the qSupported handler to split the reply into an array,
and identify features within the array rather than searching the string
for partial matches.  While at it, use StringRef.split() to process
the compression list instead of reinventing the wheel.

Switch the arguments to MaybeEnableCompression() to use an ArrayRef
of StringRefs to simplify parameter passing from GetRemoteQSupported().


https://reviews.llvm.org/D100146

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100146.336242.patch
Type: text/x-patch
Size: 8075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210408/a6b7588b/attachment-0001.bin>


More information about the lldb-commits mailing list