[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

@omjavaid Any more comments on this?



================
Comment at: lldb/include/lldb/Core/Architecture.h:110
+  virtual const MemoryTagManager *GetMemoryTagManager() const {
+    return nullptr;
+  }
----------------
I also had the thought that we could just return instances of MemoryTagManager, however we rely on virtual functions for the implementation. (incredibly obvious once you try it, but would have been nice to remove a bunch of pointer indirection)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95602/new/

https://reviews.llvm.org/D95602