[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

Tue Apr 6 09:46:03 PDT 2021

stella.stamenova added a subscriber: teemperor.
stella.stamenova added a comment.

It looks like @teemperor fixed it already!

In D99694#2671640 <https://reviews.llvm.org/D99694#2671640>, @stella.stamenova wrote:

> The latest change (commit be0ced03 <https://reviews.llvm.org/rGbe0ced03ba9bfab6fcb1fd2c263a33bc6a359cd8>) issues the following warning:
>
>   /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lldb/source/Plugins/Language/ObjC -I/mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC -Itools/lldb/source -I/mnt/vss/_work/2/s/lldb/include -Itools/lldb/include -Iinclude -I/mnt/vss/_work/2/s/llvm/include -I/usr/include/python3.8 -I/mnt/vss/_work/2/s/llvm/../clang/include -Itools/lldb/../clang/include -I/usr/include/libxml2 -I/mnt/vss/_work/2/s/lldb/source/. -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o -MF tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o.d -o tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o -c /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
>   /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:528:11: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
>             return false;
>             ^
>   /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:525:9: note: previous statement is here
>           if (log) 
>
> For this badly indented code:
>
>   if (is_preserved_number) {
>   if (log) 
>     log->Printf("Unsupported preserved NSNumber tagged pointer 0x%" 
>         PRIu64, valobj_addr);
>     return false;
>   }

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99694/new/

https://reviews.llvm.org/D99694