[Lldb-commits] [PATCH] D99729: [lldb] Improve CPUInfo test predicate
David Spickett via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 6 02:46:57 PDT 2021
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf8f4d8f87ba4: [lldb] Improve CPUInfo test predicate (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99729/new/
https://reviews.llvm.org/D99729
Files:
lldb/packages/Python/lldbsuite/test/lldbtest.py
Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -1274,7 +1274,7 @@
# TODO other platforms, please implement this function
if not re.match(".*-.*-linux", triple):
- return False
+ return ""
# Need to do something different for non-Linux/Android targets
cpuinfo_path = self.getBuildArtifact("cpuinfo")
@@ -1284,11 +1284,10 @@
cpuinfo_path = "/proc/cpuinfo"
try:
- f = open(cpuinfo_path, 'r')
- cpuinfo = f.read()
- f.close()
+ with open(cpuinfo_path, 'r') as f:
+ cpuinfo = f.read()
except:
- return False
+ return ""
return cpuinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99729.335445.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210406/eea53390/attachment.bin>
More information about the lldb-commits
mailing list