[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added inline comments.


================
Comment at: lldb/test/API/commands/frame/recognizer/main.m:1
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
----------------
kastiglione wrote:
> teemperor wrote:
> > teemperor wrote:
> > > I guess this could also be just `stdio.h` (FWIW, the printfs in tests can also be removed as they just require including system headers and are essentially never useful).
> > Just to be clear: I'm just saying that removing `printfs` and everything else that references system headers is usually always a good idea but I'm not asking that you should remove them here too. The `stdio.h` is perfect for this patch.
> thanks for reviewing closely, a bunch of these changes were automated  and I am guilty of not looking closely (if the test passed then I didn't look closer)
I was actually just looking if we had a "check that we didn't load a type from Foundation"-kind of test (as that was the only thing that I could see this could break


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99867/new/

https://reviews.llvm.org/D99867