[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil created this revision.
jankratochvil added a reviewer: JDevlieghere.
jankratochvil added a project: LLDB.
jankratochvil requested review of this revision.

  Failed Tests (1):
    lldb-shell :: Error/assert.test

LLDB on Linux built with symbols is showing this error. I was not bisecting when it happened (my buildbot builds without symbols) but I find the fix obvious.
Without symbols it still PASSes:

  lldb-test: /home/jkratoch/redhat/llvm-monorepo/lldb/source/Utility/LLDBAssert.cpp:29: void lldb_private::lldb_assert(bool, const char *, const char *, const char *, unsigned int): Assertion `false && "lldb_assert failed"' failed.

With symbols it FAILs:

  lldb-test: /home/jkratoch/redhat/llvm-monorepo/lldb/tools/lldb-test/lldb-test.cpp:1086: int opts::assert::lldb_assert(lldb_private::Debugger &): Assertion `false && "lldb-test assert"' failed.

For the symbols build using:

  time cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Debug -DLLVM_USE_LINKER=lld -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_USE_SPLIT_DWARF=OFF -DCMAKE_CXX_FLAGS="-gsplit-dwarf=single" -DCMAKE_C_FLAGS="-gsplit-dwarf=single" -GNinja


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99462

Files:
  lldb/test/Shell/Error/assert.test


Index: lldb/test/Shell/Error/assert.test
===================================================================
--- lldb/test/Shell/Error/assert.test
+++ lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "lldb_assert failed"
+# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99462.333709.patch
Type: text/x-patch
Size: 403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210328/92db9340/attachment.bin>