[Lldb-commits] [PATCH] D99446: [lldb] Add consistency between reading the dynamic and shared cache class info

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h:347
+
+  class SharedCacheClassInfoExtractor {
+  public:
----------------
Doxygen comment?


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h:349
+  public:
+    SharedCacheClassInfoExtractor(AppleObjCRuntimeV2 &runtime)
+        : m_runtime(runtime) {}
----------------
Should this implement a shared interface with DynamicClassInfoExtractor or am I just being obnoxious?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99446/new/

https://reviews.llvm.org/D99446