[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

[Justin Cohen via Phabricator via lldb-commits]

justincohen added a comment.

> OK we may need to retain the manual setting when I upstream this, instead of going with the pure Process-maintained value determined dynamically by gdb packet or corefile metadata.  If this is something you need for your own FixCodeAddress prelim patch, I can upstream the target.process.virtual-addressable-bits setting (I think the name is fine, even once Process can determine this dynamically).  We'll need to decide at some point what the correct behavior is when they conflict, but if only one is set the choice is straightforward.

Were you able to confirm if sysctlbyname "machdep.virtual_address_size" works on iOS? I'm currently hard coding this information in minidump creation, as it's failing for me.

I uploaded https://reviews.llvm.org/D98886 which reads a mask from a minidump and sets target.process.pointer-authentication-address-mask.  Would you consider that (as I assume this is going to be converted into a mask regardless, and I if there's a possibility for future non-contiguous bits)

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98529/new/

https://reviews.llvm.org/D98529