[Lldb-commits] [PATCH] D98886: Strip pointer authentication codes from MacOSX arc pc.

[Mark Mentovai via Phabricator via lldb-commits]

markmentovai added inline comments.


================
Comment at: lldb/source/Plugins/Process/minidump/MinidumpParser.cpp:241-242
+
+  const CrashpadInfo *crashpad_info =
+      reinterpret_cast<const CrashpadInfo *>(data.data());
+
----------------
Check that crashpad_info->version is 1 before attempting to treat what follows as pointer_authentication_address_mask.


================
Comment at: lldb/source/Plugins/Process/minidump/MinidumpTypes.h:113
+
+struct CrashpadInfo {
+  llvm::support::ulittle32_t version;
----------------
Ensure alignment is compatible with what Crashpad uses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98886/new/

https://reviews.llvm.org/D98886