[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9505
+    void *opaque_decl_ctx, ConstString *instance_var_name_ptr,
+    bool *instance_is_pointer_ptr) {
   if (opaque_decl_ctx) {
----------------
Another nicer way to implement an API with multiple return values would be to return a `struct ClassMethodDescriptor` or something like that.


================
Comment at: lldb/source/Target/StackFrame.cpp:566
+          else
+            var_expr_storage = ".";
           var_expr_storage += var_expr;
----------------
Ideally we would call into the LanguageRuntime here and ask it what the syntax for member access is in this language.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98653/new/

https://reviews.llvm.org/D98653