[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

Wed Mar 24 07:56:59 PDT 2021

teemperor added a comment.

In D95713#2647722 <https://reviews.llvm.org/D95713#2647722>, @davezarzycki wrote:

> In D95713#2647548 <https://reviews.llvm.org/D95713#2647548>, @teemperor wrote:
>
>> The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind `#ifdef LLDB_ENABLE_PYTHON` should fix this.
>
> My cron job is not intentionally disabling python support. That just happened to be the fallout from the normal feature detection dance before the build starts:
>
> - Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) (Required is at least version "3.0")
> - SWIG 3 or later is required for Python support in LLDB but could not be found
> - Could NOT find PythonAndSwig (missing: Python3_LIBRARIES Python3_INCLUDE_DIRS SWIG_EXECUTABLE)
> - Enable Python scripting support in LLDB: FALSE

To clarify what I meant: The patch is wrong and the tests should not fail when SWIG>3 can't be found (which disables Python support). I was just pointing out what's the bug here. That your setup doesn't have SWIG>3 is perfectly fine (I'm in fact setting up another bot that is disabling SWIG/Python right now because this doesn't seem really covered beside the Windows bot and your bisect one)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95713/new/

https://reviews.llvm.org/D95713