[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

[David Blaikie via Phabricator via lldb-commits]

dblaikie added inline comments.


================
Comment at: lldb/source/API/SBDebugger.cpp:857
+        error = m_opaque_sp->GetTargetList().CreateTarget(
+            *m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp,
+            target_sp);
----------------
clayborg wrote:
> jingham wrote:
> > dblaikie wrote:
> > > jingham wrote:
> > > > clayborg wrote:
> > > > > I submit with "arc diff" and it will cause lint errors if I don't allow it to fix the lint errors it finds.
> > > > I'm 100% not in favor of tools that force irrelevant changes to be included.  But that is a suggested tool so somebody must like that.
> > > They aren't forced - you can submit with linter errors if they don't seem helpful.
> > > 
> > > Pre-committing format changes in standalone NFC commits would generally be preferable. & the linter shouldn't be flagging untouched lines - is it?
> > It looks like the file had changes 700 lines before & 900 lines after, but these lines weren't changed except by the linter... 
> Actually come to thing about it, it is probably because my editor removes trailing newlines and then the linter deems those lines fair game...
Yeah, if your editor is touching otherwise unmodified lines that'll be a problem (for the linter, or without the linter - you'd end up with unrelated changes in the diff, etc).

clang-format can be integrated into some editors (vim, for instance) to auto-format only changed lines on save, which is what I use - not sure if there's an option to use that in your workflow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97739/new/

https://reviews.llvm.org/D97739