[Lldb-commits] [PATCH] D98914: Make target.process.stop-on-sharedlibrary-events setting work

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added a reviewer: JDevlieghere.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This setting is supposed to make us stop when we hit a shared library event.  The shared library event callbacks happen as synchronous breakpoint callbacks - below the level of user callbacks.  The information that the synchronous callback wanted to stop was getting propagated to the StopInfoBreakpoint correctly, but then we lost that bit of information when we went to do PerformAction.  This patch takes that into account.

In this patch, if the synchronous callback says to stop, but the user has another breakpoint that's auto-continue, or a callback that says to continue, at the same spot, I obey the other breakpoint's opinions rather than the callback one.  That seems to me right since the sync callbacks we have around are implementation details and the user can't even really know where they might be easily.  So having them collide with the user's intentions doesn't seem right.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98914

Files:
  lldb/source/Breakpoint/BreakpointOptions.cpp
  lldb/source/Target/StopInfo.cpp
  lldb/test/API/functionalities/stop-on-sharedlibrary-load/Makefile
  lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py
  lldb/test/API/functionalities/stop-on-sharedlibrary-load/a.cpp
  lldb/test/API/functionalities/stop-on-sharedlibrary-load/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98914.331744.patch
Type: text/x-patch
Size: 7592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210319/ede530ae/attachment.bin>