[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

[Michał Górny via Phabricator via lldb-commits]

mgorny updated this revision to Diff 331327.
mgorny marked 2 inline comments as done.
mgorny added a comment.

- switched thread-id parsing to use `view.consumeInteger()` and replaced `m_index` manipulations with a single update at the very end
- added additional test for parsing multiple thread-ids in a single packet (to verify that `m_index` is correctly updated)
- moved thread-id constants to `static constexpr` inside the class
- replaced `GDBError` with plain `StringError`s


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98482/new/

https://reviews.llvm.org/D98482

Files:
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  lldb/source/Utility/StringExtractorGDBRemote.cpp
  lldb/test/API/tools/lldb-server/TestGdbRemote_vContThreads.py
  lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
  lldb/unittests/Utility/CMakeLists.txt
  lldb/unittests/Utility/StringExtractorGDBRemoteTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98482.331327.patch
Type: text/x-patch
Size: 24637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210317/cdfb1a87/attachment-0001.bin>