[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

Tue Mar 16 11:18:28 PDT 2021

amccarth added a comment.

This workaround seems consistent with other overrides of FixCodeAddress, my only concern is about the assumption of the number of bits that need to be preserved/stripped.

I hope @jasonmolenda gets a chance to chime in.

================
Comment at: lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h:68
+    // should be removed once full PAC support is added.
+    return pc & 0x0000000FFFFFFFFF;
+  }
----------------
Is that mask correct?  If I'm counting correctly, it looks like it's preserving the lower 36 bits.  I thought most 64-bit CPUs are configured to handle up to 40 or 48 bits of virtual address space.

I assume that future PAC support will check the CPU configuration, but is 36 bits the right assumption for this workaround?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98529/new/

https://reviews.llvm.org/D98529