[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

Mon Mar 15 22:57:56 PDT 2021

nealsid added a comment.

In D98153#2610953 <https://reviews.llvm.org/D98153#2610953>, @teemperor wrote:

> Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr checks that affect a normal LLDB session (not sure if we can ever have no SymbolContext) or is this just for the unit test?
>
> Anyway, I have some small inline comments but otherwise this looks pretty good to me.

Thanks again for the review! I should have addressed everything with the new diff I just uploaded, but I'm still not sure about the pre-merge check failures because it looks (to me) like the build bot should have "lldb" in its cmake command, although I will freely admit zero experience with LLVM's build infrastructure :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98153/new/

https://reviews.llvm.org/D98153