[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

[David Zarzycki via Phabricator via lldb-commits]

davezarzycki updated this revision to Diff 329613.
davezarzycki added a comment.

I believe I have addressed all of the feedback to date.

For people that care about easily identifying the failures from the previous testing run, that is now encoded via the sign of the test time (please remember that negative test times are impossible). For example:

3.14159 a-successful-test.txt
-2.71828 a-failed-test.txt

I've also implemented but commented out how one might use this to implement `--only-failures`. Feedback would be appreciated but I don't want to derail this change proposal on what should be an independent change.

Finally, python is not my native programming language, so thank you for helping me with idiomatic changes. What I'd really like help with though is figuring out a way to not pass the prior test timing data down as a new parameter to various methods. I tried to hang the data off the test suite data structure but that had brutal performance side effects. It seemed like python was hammering on the global interpreter lock despite the prior timing data being unused after the sorting phase. Weird. Help would be greatly appreciated. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98179/new/

https://reviews.llvm.org/D98179

Files:
  libcxx/utils/libcxx/test/format.py
  libcxx/utils/libcxx/test/googlebenchmark.py
  lldb/test/API/lldbtest.py
  llvm/docs/CommandGuide/lit.rst
  llvm/test/Unit/lit.cfg.py
  llvm/utils/lit/lit/Test.py
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/cl_arguments.py
  llvm/utils/lit/lit/discovery.py
  llvm/utils/lit/lit/formats/base.py
  llvm/utils/lit/lit/formats/googletest.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/Inputs/early-tests/aaa.txt
  llvm/utils/lit/tests/Inputs/early-tests/bbb.txt
  llvm/utils/lit/tests/Inputs/early-tests/lit.cfg
  llvm/utils/lit/tests/Inputs/early-tests/subdir/ccc.txt
  llvm/utils/lit/tests/Inputs/reorder/.lit_test_times.txt
  llvm/utils/lit/tests/Inputs/reorder/aaa.txt
  llvm/utils/lit/tests/Inputs/reorder/bbb.txt
  llvm/utils/lit/tests/Inputs/reorder/lit.cfg
  llvm/utils/lit/tests/Inputs/reorder/subdir/ccc.txt
  llvm/utils/lit/tests/early-tests.py
  llvm/utils/lit/tests/ignore-fail.py
  llvm/utils/lit/tests/reorder.py
  llvm/utils/lit/tests/shtest-shell.py
  mlir/test/Unit/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98179.329613.patch
Type: text/x-patch
Size: 21262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210310/6a600d1d/attachment-0001.bin>