[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

Tue Mar 9 01:10:57 PST 2021

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D98197#2613227 <https://reviews.llvm.org/D98197#2613227>, @jankratochvil wrote:

>> I guess we should also delete `test/Shell/Breakpoint/implicit_const_form_support.test`, as it's not very useful (the numbers it checks come from the line table, not from the implicit constants).
>
> I have not deleted it myself; I find non-racy simple tests to be always good as they may catch some completely unrelated regression in the future.

Fine, I'll do it afterwards. :) If it was at least testing what it claims it's testing, I might keep it. However, judging by the need to re-fix implicit const support, it's not doing a good job at even that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98197/new/

https://reviews.llvm.org/D98197