[Lldb-commits] [lldb] 1200f85 - [lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 8 22:35:23 PST 2021


Author: Dave Lee
Date: 2021-03-08T22:34:56-08:00
New Revision: 1200f85818d16e4f0a57c503e186df7a8ad92435

URL: https://github.com/llvm/llvm-project/commit/1200f85818d16e4f0a57c503e186df7a8ad92435
DIFF: https://github.com/llvm/llvm-project/commit/1200f85818d16e4f0a57c503e186df7a8ad92435.diff

LOG: [lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment

This comment was present twice in the function.

Added: 
    

Modified: 
    lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp b/lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp
index f188d827faae..1cb11dc676ba 100644
--- a/lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp
+++ b/lldb/source/Target/ThreadPlanStepOverBreakpoint.cpp
@@ -49,16 +49,6 @@ bool ThreadPlanStepOverBreakpoint::ValidatePlan(Stream *error) { return true; }
 bool ThreadPlanStepOverBreakpoint::DoPlanExplainsStop(Event *event_ptr) {
   StopInfoSP stop_info_sp = GetPrivateStopInfo();
   if (stop_info_sp) {
-    // It's a little surprising that we stop here for a breakpoint hit.
-    // However, when you single step ONTO a breakpoint we still want to call
-    // that a breakpoint hit, and trigger the actions, etc.  Otherwise you
-    // would see the
-    // PC at the breakpoint without having triggered the actions, then you'd
-    // continue, the PC wouldn't change,
-    // and you'd see the breakpoint hit, which would be odd. So the lower
-    // levels fake "step onto breakpoint address" and return that as a
-    // breakpoint.  So our trace step COULD appear as a breakpoint hit if the
-    // next instruction also contained a breakpoint.
     StopReason reason = stop_info_sp->GetStopReason();
 
     Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));


        


More information about the lldb-commits mailing list